1. Forum
  2. fidonet
  3. syncsyso

  • PETSCII issues with terminal-abstraction branch

    From Rob Swindell@1:103/705 to GitLab issue in main/sbbs on Friday, March 28, 2025 10:05:34
    open https://gitlab.synchro.net/main/sbbs/-/issues/894

    There's a "[Hit a key]" prompt immediately displayed when connecting to C64 port on cvs.synchro.net (TCP port 64):
    ```
    Synchronet BBS for Linux Version 3.20
    Telnet connection from: 71.95.196.34
    Resolving hostname...

    [Hit a key]
    ```
    This doesn't happen on the master branch.
    --- SBBSecho 3.24-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to GitLab note in main/sbbs on Friday, March 28, 2025 10:06:27
    https://gitlab.synchro.net/main/sbbs/-/issues/894#note_6892

    There's a pause prompt after the answer message is displayed and before the login prompt:
    ```
    Synchronet BBS for Linux Version 3.20
    Copyright 2025 Rob Swindell


    V E R T R A U E N
    ▄▄ ▄
      ┌🮃 🮃  
      ┌┘   ▄🮃🮃▄ 🮃 ▄ ┌ ▄▄ ─ ───
    ┌─  ┌┴──    ┌🮃  ─┘ 🮃  
      ├───    ┌┘    
      │    ──┘    
    🮃    ▄──🮃 ▄ ▄ ▄ ▄ ▄ ▄ ▄ ▄ ▄
    🮃 🮃🮃🮃 🮃🮃 🮃🮃
    Vertrauen - Home of Synchronet BBS

    [Hit a key]
    ```
    This doesn't happen on the master branch.
    --- SBBSecho 3.24-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to GitLab note in main/sbbs on Friday, March 28, 2025 10:10:08
    https://gitlab.synchro.net/main/sbbs/-/issues/894#note_6893

    Progress indicator isn't being cleared:
    ```
    CLIENT CONN: Telnet
    ADDR: vert.synchro.net [71.95.19
    TERM: 40x25 CBM-ASCII / PETSCII
    SERVER NAME: Vertrauen
    ADDR: cvs.synchro.net
    NODE: 11 (of 17) - Debian GNU/Li
    TIME: Fri Mar 28 2025 10:07 am P
    ADMN: digital man

    If you are a new user to the system,
    type "New" now.
    Otherwise, enter your user name or
    number now.

    Enter User Name or Number or 'New' or
    'Guest'
    Login: !1
    Password: ******
    Logging on to Vertrauen
    as Digital Man ...
    [ Loading message pointers... 100.0%

    [Hit a key] =
    ```
    The "[ Loading message pointers..." line is cleared normally (master branch), but not on your branch.
    --- SBBSecho 3.24-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to GitLab note in main/sbbs on Friday, March 28, 2025 10:19:28
    https://gitlab.synchro.net/main/sbbs/-/issues/894#note_6894

    Running sbbslist.js, hitting enter or down arrow after the initial screen-full of BBSes is listed, the script goes into an infinite loop of calling getkey() with no wait and appears to be constantly clear the screen or the last line (the cursor is bouncing around the last line), with no ability to stop/quit. This doesn't happen when run on the master branch.
    --- SBBSecho 3.24-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to GitLab note in main/sbbs on Friday, March 28, 2025 10:22:18
    https://gitlab.synchro.net/main/sbbs/-/issues/894#note_6895

    After display a text file that switches to PETSCII graphics mode, the BBS isn't auto-returning to upper/lower mode, as can be seen by viewing the first PETSCII "General Text File" on Vertrauen:
    ```
    🭾🭶🭰♥🭸╮╮ ♠RTWORK 🭺ILES:

    1: AZTEC▁SHIP.SEQ
    2: CLONE▁OF▁AZTEC.SEQ
    3: CRYSTAL.SEQ
    4: JACKPOT.SEQ
    5: LIMO▁NADE▁NSTA▁ND.SEQ
    6: PYRAMID▁2.SEQ
    ```
    This doesn't happen (we auto-return to upper/lower PETSCII mode) on the master branch.
    --- SBBSecho 3.24-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Deucе@1:103/705 to GitLab note in main/sbbs on Friday, March 28, 2025 10:29:22
    https://gitlab.synchro.net/main/sbbs/-/issues/894#note_6896

    What's the SSH port for C64 on Vert?
    --- SBBSecho 3.24-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to GitLab note in main/sbbs on Friday, March 28, 2025 10:29:59
    https://gitlab.synchro.net/main/sbbs/-/issues/894#note_6897

    I don't have one.
    --- SBBSecho 3.24-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to GitLab note in main/sbbs on Friday, March 28, 2025 10:33:58
    https://gitlab.synchro.net/main/sbbs/-/issues/894#note_6898

    irc.js displays a ton of apparently redundant [Hit a key] prompts after connecting to a server. Doesn't happen on the master branch.
    --- SBBSecho 3.24-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Deucе@1:103/705 to GitLab note in main/sbbs on Friday, March 28, 2025 11:33:27
    https://gitlab.synchro.net/main/sbbs/-/issues/894#note_6901

    So this one is interesting... it looks like the reason behind this is that terminal abstraction branch knows that the cursor wrapped after printing `[ lOADING MESSAGE POINTERS... 100.0% ]` and doesn't allow cursor_left() to wrap, so the CR/CEOF takes place on the next line.

    In master however, cursor_left() behaves differently between C64 and ANSI modes, so it will wrap to the previous line, and so the CR/CEOF happens up there.

    Master in 40-column ANSI mode:

    ![image.png](/uploads/92d40ab5557a7ff271fac90012d67163/image.png)
    --- SBBSecho 3.24-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Deucе@1:103/705 to GitLab note in main/sbbs on Friday, March 28, 2025 11:40:19
    https://gitlab.synchro.net/main/sbbs/-/issues/894#note_6902

    I think ultimately this is a long-standing bug in `sbbs_t::progress` the format is currently `[ %-8s %4.1f%% ]` and it should likely be `[ %-8s %5.1f%% ]` (one less space before the percentage, enough room for 100.0 in the field width).
    --- SBBSecho 3.24-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Deucе@1:103/705 to GitLab note in main/sbbs on Friday, March 28, 2025 11:48:04
    https://gitlab.synchro.net/main/sbbs/-/issues/894#note_6904

    Fixed in terminal-abstraction branch.
    --- SBBSecho 3.24-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Deucе@1:103/705 to GitLab note in main/sbbs on Friday, March 28, 2025 11:58:44
    https://gitlab.synchro.net/main/sbbs/-/issues/894#note_6905

    Is setting `console.current_column;` supposed to allow making the console object wrong, or is it supposed to move the cursor?
    --- SBBSecho 3.24-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Deucе@1:103/705 to GitLab note in main/sbbs on Friday, March 28, 2025 12:01:51
    https://gitlab.synchro.net/main/sbbs/-/issues/894#note_6906

    This work-around shouldn't be necessary anymore:

    ```
    /* Clear the text to the end of the line on the screen. For PETSCII,
    it seems we have to take extra care to go only to the end of the line;
    console.cleartoeol() is causing a formatting issue with PETSCII. */
    if (console.term_supports(USER_PETSCII))
    {
    var prompt_text_len = console.strlen(prompt_str);
    var len_to_clear = console.screen_columns - prompt_text_len + 6;
    printf("%" + len_to_clear + "s", "");
    console.gotoxy(prompt_text_len-6, prompt_row);
    }
    else
    console.cleartoeol(); // With PETSCII, this is causing a formatting issue
    ```
    --- SBBSecho 3.24-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Deucе@1:103/705 to GitLab note in main/sbbs on Friday, March 28, 2025 12:11:34
    https://gitlab.synchro.net/main/sbbs/-/issues/894#note_6907

    len_to_clear = -26 (40 - 72 + 6)
    --- SBBSecho 3.24-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Deucе@1:103/705 to GitLab note in main/sbbs on Friday, March 28, 2025 12:20:58
    https://gitlab.synchro.net/main/sbbs/-/issues/894#note_6909

    Fixed (infinite loop caused by moving to column 66).
    --- SBBSecho 3.24-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to GitLab note in main/sbbs on Friday, March 28, 2025 12:34:44
    https://gitlab.synchro.net/main/sbbs/-/issues/894#note_6910

    We could change `console.current_column` and `current_row` to be read-only I suppose. No, it was not intended (and would not) move the cursor.
    --- SBBSecho 3.24-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Deucе@1:103/705 to GitLab note in main/sbbs on Friday, March 28, 2025 12:53:56
    https://gitlab.synchro.net/main/sbbs/-/issues/894#note_6911

    Yeah, I know it previously didn't, but we allow setting attributes, so it would make sense to allow setting row/col... and should be backward compatible... anyone actually changing it to anything but what is "correct" would be breaking something I think.
    --- SBBSecho 3.24-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to GitLab note in main/sbbs on Friday, March 28, 2025 13:01:20
    https://gitlab.synchro.net/main/sbbs/-/issues/894#note_6912

    sure, making an update to current_column/row actually move the cursor would be fine (and logical). We already have the gotoxy() method, so it is a bit redundant, but why not.
    --- SBBSecho 3.24-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Deucе@1:103/705 to GitLab note in main/sbbs on Friday, March 28, 2025 13:04:28
    https://gitlab.synchro.net/main/sbbs/-/issues/894#note_6914

    Well, gotoxy() needs to set both, ANSI allows setting either separately with different commands, so not completely redundant.

    I'll just file a new issue for it though.
    --- SBBSecho 3.24-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Deucе@1:103/705 to GitLab note in main/sbbs on Friday, March 28, 2025 13:05:33
    https://gitlab.synchro.net/main/sbbs/-/issues/894#note_6916

    Fixed. gotoxy() wasn't resetting the line counter (and it should).
    --- SBBSecho 3.24-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Deucе@1:103/705 to GitLab note in main/sbbs on Friday, March 28, 2025 13:08:08
    https://gitlab.synchro.net/main/sbbs/-/issues/894#note_6917

    #896
    --- SBBSecho 3.24-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Deucе@1:103/705 to GitLab note in main/sbbs on Friday, March 28, 2025 13:23:54
    https://gitlab.synchro.net/main/sbbs/-/issues/894#note_6920

    This one is less obvious... the sending of PETSCII_UPPERLOWER logic hasn't really changed. I assume that P_PETSCII is being set because it's a .seq file, do you know off-hand if P_OPENCLOSE is being set?
    --- SBBSecho 3.24-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to GitLab note in main/sbbs on Friday, March 28, 2025 13:51:32
    https://gitlab.synchro.net/main/sbbs/-/issues/894#note_6922

    I don't think P_OPENCLOSE would be set.
    --- SBBSecho 3.24-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to GitLab note in main/sbbs on Friday, March 28, 2025 13:56:39
    https://gitlab.synchro.net/main/sbbs/-/issues/894#note_6924

    You should be able to reproduce this on your own BBS pretty easily:
    ```
    🭱ENERAL 🭰EXT 🭺ILE ♥ECTIONS:

    <1> ╮NFORMATION
    <2> ♠╱♥╮ ♠RTWORK
    <3> 🭾🭶🭰♥🭸╮╮ ♠RTWORK
    <4> 🭻╮🭾 ♠RT
    <5> ╭🭰🭺-8 🭰ESTS
    <6> 🭽PERATOR

    ○HICH OR ●UIT:
    ```
    --- SBBSecho 3.24-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell@1:103/705 to GitLab note in main/sbbs on Friday, March 28, 2025 14:11:56
    https://gitlab.synchro.net/main/sbbs/-/issues/894#note_6925

    [aztec_ship.seq](/uploads/48e0836c3d591a6abfe246a5e66a6a0b/aztec_ship.seq)

    File used in example (transitions to PETSCII graphics mode)
    --- SBBSecho 3.24-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Deucе@1:103/705 to GitLab note in main/sbbs on Friday, March 28, 2025 14:24:37
    https://gitlab.synchro.net/main/sbbs/-/issues/894#note_6927

    Yeah, I just grabbed a .seq from cvs... fixed now... it wasn't passing the lower-case character though.
    --- SBBSecho 3.24-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Deucе@1:103/705 to GitLab issue in main/sbbs on Friday, March 28, 2025 14:25:17
    close https://gitlab.synchro.net/main/sbbs/-/issues/894
    --- SBBSecho 3.24-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Deucе@1:103/705 to GitLab note in main/sbbs on Friday, March 28, 2025 14:25:25
    https://gitlab.synchro.net/main/sbbs/-/issues/894#note_6928

    All fixed.
    --- SBBSecho 3.24-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)