1. Forum
  2. DOVE-Net
  3. Synchronet Programming

  • src/syncterm/ssh.c

    From Deuc¿@VERT to Git commit to main/sbbs/master on Friday, January 03, 2025 10:35:27
    https://gitlab.synchro.net/main/sbbs/-/commit/e15ba30749ace18e46675ec4
    Modified Files:
    src/syncterm/ssh.c
    Log Message:
    Move ssh_complete out of ssh_mutex

    Coverity seems to hate it mostly in the mutex, so change it to
    mostly outside of the mutex and see if that's fine.

    It doesn't really matter where it's changed as it's an atomic bool.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¿@VERT to Git commit to main/sbbs/master on Saturday, January 04, 2025 22:55:27
    https://gitlab.synchro.net/main/sbbs/-/commit/1326b624bd973b8e3f6e9b93
    Modified Files:
    src/syncterm/ssh.c
    Log Message:
    Fix memory leak when connection lost during SFTP key check

    Found by scan-build

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¿@VERT to Git commit to main/sbbs/master on Tuesday, January 07, 2025 13:13:00
    https://gitlab.synchro.net/main/sbbs/-/commit/ee15f3cfe79bf6f5f0486f3e
    Modified Files:
    src/syncterm/ssh.c
    Log Message:
    Remove more redundant code

    ssh_active was never set to false anymore
    channel_gone did exactly the same thing as conn_api.terminate
    change read/write timeouts to zero when closing

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¿@VERT to Git commit to main/sbbs/master on Tuesday, January 07, 2025 13:16:42
    https://gitlab.synchro.net/main/sbbs/-/commit/0ad896e3b34767ba64207875
    Modified Files:
    src/syncterm/ssh.c
    Log Message:
    Remove likely obsolete Coverity suppression.

    It can be added back if the issue reappears.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¿@VERT to Git commit to main/sbbs/master on Tuesday, January 07, 2025 19:23:28
    https://gitlab.synchro.net/main/sbbs/-/commit/772609493c77c12dcadf8bc4
    Modified Files:
    src/syncterm/ssh.c
    Log Message:
    assert() ssh globals are initialized correctly.

    Some weren't (mostly sftp ones though)

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¿@VERT to Git commit to main/sbbs/master on Wednesday, January 08, 2025 22:01:58
    https://gitlab.synchro.net/main/sbbs/-/commit/0ff6b5ecb393dcf2f170f68e
    Modified Files:
    src/syncterm/ssh.c
    Log Message:
    Re-add coverity suppression. Not obsolete.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net